Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

fix(crds/meshconfig): change envoy image pattern#3517

Merged
nshankar13 merged 1 commit intoopenservicemesh:mainfrom
nshankar13:edit_meshconfig_envoy_pattern
Jun 5, 2021
Merged

fix(crds/meshconfig): change envoy image pattern#3517
nshankar13 merged 1 commit intoopenservicemesh:mainfrom
nshankar13:edit_meshconfig_envoy_pattern

Conversation

@nshankar13
Copy link
Copy Markdown
Contributor

Signed-off-by: nshankar13 nshankar@microsoft.com

Description: Edit the envoy meshconfig pattern so that downstream charts can pull different envoy images.

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [X]
Security [ ]
Upgrade [ ]
Tests [ ]
CI System [ ]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

@nshankar13 nshankar13 requested a review from a team as a code owner June 4, 2021 23:42
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #3517 (ea1b12d) into main (94a9cd0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3517   +/-   ##
=======================================
  Coverage   66.27%   66.27%           
=======================================
  Files         169      169           
  Lines        8081     8081           
=======================================
  Hits         5356     5356           
  Misses       2695     2695           
  Partials       30       30           
Flag Coverage Δ
unittests 66.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94a9cd0...ea1b12d. Read the comment docs.

Signed-off-by: nshankar13 <nshankar@microsoft.com>
@nshankar13 nshankar13 force-pushed the edit_meshconfig_envoy_pattern branch from a3b2f5b to ea1b12d Compare June 5, 2021 01:10
@nshankar13 nshankar13 merged commit dc597c8 into openservicemesh:main Jun 5, 2021
@nshankar13
Copy link
Copy Markdown
Contributor Author

@Mergifyio backport release-v0.9

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 7, 2021

Command backport release-v0.9: success

Backports have been created

nshankar13 added a commit that referenced this pull request Jun 7, 2021
…/pr-3517

fix(crds/meshconfig): change envoy image pattern (backport #3517)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants